bna: integer overflow bug in debugfs
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 17 Mar 2017 20:52:35 +0000 (23:52 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 25 Dec 2017 13:22:10 +0000 (14:22 +0100)
commitb9a4a18a01fc8c96028a4062bcd686a678bb3266
tree4b6adb95a466c1cf018f43c2dbd2ffa8530ba7ee
parentffde339b95f5729e9d57ba0802b50a611854b728
bna: integer overflow bug in debugfs

[ Upstream commit 13e2d5187f6b965ba3556caedb914baf81b98ed2 ]

We could allocate less memory than intended because we do:

bnad->regdata = kzalloc(len << 2, GFP_KERNEL);

The shift can overflow leading to a crash.  This is debugfs code so the
impact is very small.

Fixes: 7afc5dbde091 ("bna: Add debugfs interface.")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Rasesh Mody <rasesh.mody@cavium.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/brocade/bna/bnad_debugfs.c