clocksource/drivers: Fix uninitialized variable use in timer_of_init
authorArnd Bergmann <arnd@arndb.de>
Wed, 21 Jun 2017 21:49:54 +0000 (23:49 +0200)
committerThomas Gleixner <tglx@linutronix.de>
Wed, 21 Jun 2017 22:04:26 +0000 (00:04 +0200)
commitb7dcc4eacc45263ac5d3a0bd78c64e9ff7c94c13
tree715095fb3cbc4e21d59acf6f6fcfafdf59369f23
parent17d9d6875ce89c0c98bb54d4d5649efb22986bf3
clocksource/drivers: Fix uninitialized variable use in timer_of_init

If none of the flags are set, 'ret' is uninitialized as pointed out
by gcc:

drivers/clocksource/timer-of.c: In function 'timer_of_init':
drivers/clocksource/timer-of.c:160:9: error: 'ret' may be used uninitialized in this function [-Werror=maybe-uninitialized]

Since calling the function without any of the flags is an error,
set the return value to -EINVAL for that case.

[ tglx: Get rid of the silly backwards goto while at it ]

Fixes: dc11bae78529 ("clocksource/drivers: Add timer-of common init routine")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: http://lkml.kernel.org/r/20170621215005.3870011-1-arnd@arndb.de
drivers/clocksource/timer-of.c