net: Fix disjunct computation of netdev features
authorHerbert Xu <herbert@gondor.apana.org.au>
Thu, 23 Oct 2008 08:11:29 +0000 (01:11 -0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 23 Oct 2008 08:11:29 +0000 (01:11 -0700)
commitb63365a2d60268a3988285d6c3c6003d7066f93a
tree85bd8f91f3de954c697aa44544b4adf191e7f5aa
parent2e3f92dad6bdbee796274bae5c1c50a6ddd31cbb
net: Fix disjunct computation of netdev features

My change

    commit e2a6b85247aacc52d6ba0d9b37a99b8d1a3e0d83
    net: Enable TSO if supported by at least one device

didn't do what was intended because the netdev_compute_features
function was designed for conjunctions.  So what happened was that
it would simply take the TSO status of the last constituent device.

This patch extends it to support both conjunctions and disjunctions
under the new name of netdev_increment_features.

It also adds a new function netdev_fix_features which does the
sanity checking that usually occurs upon registration.  This ensures
that the computation doesn't result in an illegal combination
since this checking is absent when the change is initiated via
ethtool.

The two users of netdev_compute_features have been converted.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/bonding/bond_main.c
include/linux/netdevice.h
net/bridge/br_device.c
net/bridge/br_if.c
net/core/dev.c