watchdog: dw_wdt: Try to get a 30 second watchdog by default
authorDoug Anderson <dianders@chromium.org>
Tue, 27 Jan 2015 22:25:17 +0000 (14:25 -0800)
committerWim Van Sebroeck <wim@iguana.be>
Tue, 17 Feb 2015 20:33:49 +0000 (21:33 +0100)
commitb5ade9bc8dca839fb06cd2788046cfe923c06980
tree1686491b894f9d2a47bdc02078ecd7910da23040
parenta00850107eb050bf6427a8f3a0445bce9441b5df
watchdog: dw_wdt: Try to get a 30 second watchdog by default

The dw_wdt_set_top() function takes in a value in seconds.  In
dw_wdt_open() we were calling it with a value that's supposed to
represent the maximum value programmed into the "top" register with a
comment saying that we were trying to set the watchdog to its maximum
value.  Instead we ended up setting the watchdog to ~15 seconds.

Let's fix this.  However, setting things to the "max" gives me an 86
second watchdog in the system I'm looking at.  86 seconds feels a
little too long.  We'll explicitly choose 30 seconds as a more
reasonable value.

NOTE: Ideally this driver should be transitioned to be a real watchdog
driver.  Then we could use "watchdog_init_timeout" and let the timeout
be specified in a number of ways (device tree, module parameter, etc).
This patch should be considered a bit of a stopgap solution.

Signed-off-by: Doug Anderson <dianders@chromium.org>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
drivers/watchdog/dw_wdt.c