xen: explicitly create/destroy stop_machine workqueues outside suspend/resume region.
authorIan Campbell <ian.campbell@citrix.com>
Tue, 1 Dec 2009 11:47:15 +0000 (11:47 +0000)
committerJeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
Thu, 3 Dec 2009 19:14:56 +0000 (11:14 -0800)
commitb4606f2165153833247823e8c04c5e88cb3d298b
treeccbfa5eec0ea6c39f34de45ee1f0665288d6c1f1
parent65f63384b391bf4d384327d8a7c6de9860290b5c
xen: explicitly create/destroy stop_machine workqueues outside suspend/resume region.

I have observed cases where the implicit stop_machine_destroy() done by
stop_machine() hangs while destroying the workqueues, specifically in
kthread_stop(). This seems to be because timer ticks are not restarted
until after stop_machine() returns.

Fortunately stop_machine provides a facility to pre-create/post-destroy
the workqueues so use this to ensure that workqueues are only destroyed
after everything is really up and running again.

I only actually observed this failure with 2.6.30. It seems that newer
kernels are somehow more robust against doing kthread_stop() without timer
interrupts (I tried some backports of some likely looking candidates but
did not track down the commit which added this robustness). However this
change seems like a reasonable belt&braces thing to do.

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
Cc: Stable Kernel <stable@kernel.org>
drivers/xen/manage.c