task_work: Revert "hold task_lock around checks in keyctl"
authorOleg Nesterov <oleg@redhat.com>
Sun, 26 Aug 2012 19:12:14 +0000 (21:12 +0200)
committerIngo Molnar <mingo@kernel.org>
Thu, 13 Sep 2012 14:47:36 +0000 (16:47 +0200)
commitb3f68f16dbcde6fcdf0fd27695391ff7e9d41233
tree26833634b038b8fd9d18f109deb10770eb3f2a6e
parent9da33de62431c7839f98156720862262272a8380
task_work: Revert "hold task_lock around checks in keyctl"

This reverts commit d35abdb28824cf74f0a106a0f9c6f3ff700a35bf.

task_lock() was added to ensure exit_mm() and thus exit_task_work() is
not possible before task_work_add().

This is wrong, task_lock() must not be nested with write_lock(tasklist).
And this is no longer needed, task_work_add() now fails if it is called
after exit_task_work().

Reported-by: Dave Jones <davej@redhat.com>
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Link: http://lkml.kernel.org/r/20120826191214.GA4231@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
security/keys/keyctl.c