enic: Bug fix: use safe queue shutdown in dev->stop
authorScott Feldman <scofeldm@cisco.com>
Wed, 23 Dec 2009 13:27:30 +0000 (13:27 +0000)
committerDavid S. Miller <davem@davemloft.net>
Thu, 24 Dec 2009 05:03:39 +0000 (21:03 -0800)
commitb3d18d191bb805f3effdfc083c4ce79789470b46
tree034a2d4cfda07b9f843942bc33a3e43ea2572489
parentfe45332ed289d91e57eca11bfd1ca75d6e420ab4
enic: Bug fix: use safe queue shutdown in dev->stop

Fix dev->stop shutdown bug where driver was stopping xmit queue and then
disabling intrs.  Fix is to disable intrs first and then stop the xmit
queue, otherwise an interrupt could cause the queue to be rewoken.  Also,
no need to explicitly do queue servicing because queues are cleaned and
reset back to initial state at end of dev->stop.  Servicing queues also
had the side-effect of also rewakening the xmit queue, which is not what
we want.

Signed-off-by: Vasanthy Kolluri <vkolluri@cisco.com>
Signed-off-by: Scott Feldman <scofeldm@cisco.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/enic/enic.h
drivers/net/enic/enic_main.c
drivers/net/enic/vnic_intr.h