IB/core: Don't resolve passive side RoCE L2 address in CMA REQ handler
authorMoni Shoua <monis@mellanox.com>
Thu, 27 Mar 2014 08:52:58 +0000 (10:52 +0200)
committerRoland Dreier <roland@purestorage.com>
Tue, 1 Apr 2014 21:05:26 +0000 (14:05 -0700)
commitb2853fd6c2d0f383dbdf7427e263eb576a633867
treec82122c657ab89679fc10a298ac3c8ffef31deac
parentcfbf8d4857c26a8a307fb7cd258074c9dcd8c691
IB/core: Don't resolve passive side RoCE L2 address in CMA REQ handler

The code that resolves the passive side source MAC within the rdma_cm
connection request handler was both redundant and buggy, so remove it.

It was redundant since later, when an RC QP is modified to RTR state,
the resolution will take place in the ib_core module.  It was buggy
because this callback also deals with UD SIDR exchange, for which we
incorrectly looked at the REQ member of the CM event and dereferenced
a random value.

Fixes: dd5f03beb4f7 ("IB/core: Ethernet L2 attributes in verbs/cm structures")
Signed-off-by: Moni Shoua <monis@mellanox.com>
Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
Signed-off-by: Roland Dreier <roland@purestorage.com>
drivers/infiniband/core/cm.c
drivers/infiniband/core/cma.c
include/rdma/ib_cm.h