powerpc/perf/hv-24x7: Fix incorrect comparison in memord
authorMichael Ellerman <mpe@ellerman.id.au>
Mon, 9 Oct 2017 10:52:44 +0000 (21:52 +1100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 20 Dec 2017 09:05:00 +0000 (10:05 +0100)
commitafa8f0a7af7041665443603ee3c20609733ce940
treecc13006d755114c7af99e5eaca0f3e55f80a399f
parent28a5b0e438f18bbacc977a38cf47b3d265ac3d27
powerpc/perf/hv-24x7: Fix incorrect comparison in memord

[ Upstream commit 05c14c03138532a3cb2aa29c2960445c8753343b ]

In the hv-24x7 code there is a function memord() which tries to
implement a sort function return -1, 0, 1. However one of the
conditions is incorrect, such that it can never be true, because we
will have already returned.

I don't believe there is a bug in practice though, because the
comparisons are an optimisation prior to calling memcmp().

Fix it by swapping the second comparision, so it can be true.

Reported-by: David Binderman <dcb314@hotmail.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
arch/powerpc/perf/hv-24x7.c