projects / GitHub / LineageOS / android_kernel_motorola_exynos9610.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 977e209) | patch
greybus: firmware: fix potential stack corruption
authorJohan Hovold <johan@hovoldconsulting.com>
Fri, 28 Aug 2015 09:58:24 +0000 (11:58 +0200)
committerJohan Hovold <johan@hovoldconsulting.com>
Tue, 1 Sep 2015 12:42:02 +0000 (14:42 +0200)
commitaf0b4d5a19e3d49059afe91307fce980291f43f9
tree95ea957c84872bbe0fa4bd5cd271be737e083907tree | snapshot (tar.gz zip)
parent977e209ab41073def3cf0e1034c429a832ba54dfcommit | diff
greybus: firmware: fix potential stack corruption

Use snprintf when generating the firmware name to avoid stack corruption
if the fixed-size buffer overflows.

Note that the current buffer size appears to expect 16-bit ids while
the they are actually 32-bit, something which could trigger the
corruption.

Signed-off-by: Johan Hovold <johan@hovoldconsulting.com>
Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
drivers/staging/greybus/firmware.c diff | blob | blame | history