lib/xz: Validate the value before assigning it to an enum variable
authorLasse Collin <lasse.collin@tukaani.org>
Sun, 10 Oct 2021 21:31:40 +0000 (05:31 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 26 Nov 2021 10:48:30 +0000 (11:48 +0100)
commitad78ed60a7f13b291e6e2059164f637ab3a44435
tree431585b21f1eade306d33a78d0e20900f4952de3
parent9cea212f2ceec5ae4ec83aa01b0a1caf05ea5506
lib/xz: Validate the value before assigning it to an enum variable

[ Upstream commit 4f8d7abaa413c34da9d751289849dbfb7c977d05 ]

This might matter, for example, if the underlying type of enum xz_check
was a signed char. In such a case the validation wouldn't have caught an
unsupported header. I don't know if this problem can occur in the kernel
on any arch but it's still good to fix it because some people might copy
the XZ code to their own projects from Linux instead of the upstream
XZ Embedded repository.

This change may increase the code size by a few bytes. An alternative
would have been to use an unsigned int instead of enum xz_check but
using an enumeration looks cleaner.

Link: https://lore.kernel.org/r/20211010213145.17462-3-xiang@kernel.org
Signed-off-by: Lasse Collin <lasse.collin@tukaani.org>
Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
lib/xz/xz_dec_stream.c