dma: mv_xor: fix error handling of mv_xor_channel_add()
authorThomas Petazzoni <thomas.petazzoni@free-electrons.com>
Sun, 6 Jan 2013 10:10:43 +0000 (11:10 +0100)
committerJason Cooper <jason@lakedaemon.net>
Sun, 6 Jan 2013 17:53:25 +0000 (17:53 +0000)
commitab6e439fd07aba7cadcadb3fb5e11d3758e19679
treef123a743e71256d792a28a56e7cc3b8ee63b11d7
parent41be8dc1a44ee2a0a52bdf2b77273624c40782b6
dma: mv_xor: fix error handling of mv_xor_channel_add()

When mv_xor_channel_add() fails for one XOR channel, we jump to the
err_channel_add label to clean up all previous channels that had been
initialized correctly. Unfortunately, while handling this error
condition, we were disposing the IRQ mapping before calling
mv_xor_channel_remove() (which does the free_irq()), which is
incorrect.

Instead, do things properly in the reverse order of the
initialization: first remove the XOR channel (so that free_irq() is
done), and then dispose the IRQ mapping.

This avoids ugly warnings when for some reason one of the XOR channel
fails to initialize.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
drivers/dma/mv_xor.c