projects / GitHub / moto-9609 / android_kernel_motorola_exynos9610.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 92e963f) | patch
PCI: Check device_attach() return value always
authorBjorn Helgaas <bhelgaas@google.com>
Wed, 27 Jan 2016 13:35:07 +0000 (07:35 -0600)
committerBjorn Helgaas <bhelgaas@google.com>
Fri, 5 Feb 2016 20:56:57 +0000 (14:56 -0600)
commitab1a187bba5c4e5ed8aa6e7bb7dcd7cd7e065aef
treee724eb5be84d0c98fcbccc0c78b475bd0174350atree | snapshot (tar.gz zip)
parent92e963f50fc74041b5e9e744c330dca48e04f08dcommit | diff
PCI: Check device_attach() return value always

Previously we checked the device_attach() return value only when
CONFIG_BUG=y.  That caused this warning in builds where CONFIG_BUG is not
set:

  drivers/pci/bus.c:237:6: warning: variable 'retval' set but not used [-Wunused-but-set-variable]

Check the return value of device_attach() always and clean up after
failure.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/pci/bus.c diff | blob | blame | history