dm crypt: use kstrdup
authorJulia Lawall <julia@diku.dk>
Thu, 12 Aug 2010 03:13:58 +0000 (04:13 +0100)
committerAlasdair G Kergon <agk@redhat.com>
Thu, 12 Aug 2010 03:13:58 +0000 (04:13 +0100)
commita9c88f2ebc1a5937915cb3b89c9f03894134f39a
tree84f409698a8b0c861b91f90dc8e8043009132398
parent402ab352c2c00ba8f90c724565f8cf31210d99cf
dm crypt: use kstrdup

Use kstrdup when the goal of an allocation is copy a string into the
allocated region.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression from,to;
expression flag,E1,E2;
statement S;
@@

-  to = kmalloc(strlen(from) + 1,flag);
+  to = kstrdup(from, flag);
   ... when != \(from = E1 \| to = E1 \)
   if (to==NULL || ...) S
   ... when != \(from = E2 \| to = E2 \)
-  strcpy(to, from);
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Alasdair G Kergon <agk@redhat.com>
drivers/md/dm-crypt.c