ext4: avoid deadlock when expanding inode size
authorJan Kara <jack@suse.cz>
Thu, 11 Aug 2016 16:38:55 +0000 (12:38 -0400)
committerDanny Wood <danwood76@gmail.com>
Tue, 29 Jan 2019 13:18:21 +0000 (13:18 +0000)
commita5a490bbe22ee15d7cd31d5218a0fc671debf95d
tree8c08466399a0208496d573fb8faced61a9568bba
parent2f5b62d9dee4d4186908a910337de5492b6b12ce
ext4: avoid deadlock when expanding inode size

commit 2e81a4eeedcaa66e35f58b81e0755b87057ce392 upstream.

When we need to move xattrs into external xattr block, we call
ext4_xattr_block_set() from ext4_expand_extra_isize_ea(). That may end
up calling ext4_mark_inode_dirty() again which will recurse back into
the inode expansion code leading to deadlocks.

Protect from recursion using EXT4_STATE_NO_EXPAND inode flag and move
its management into ext4_expand_extra_isize_ea() since its manipulation
is safe there (due to xattr_sem) from possible races with
ext4_xattr_set_handle() which plays with it as well.

CC: stable@vger.kernel.org # 4.4.x
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Willy Tarreau <w@1wt.eu>
fs/ext4/inode.c
fs/ext4/xattr.c