media: s5p-mfc: Fix a reference count leak
authorQiushi Wu <wu000273@umn.edu>
Sun, 14 Jun 2020 02:31:22 +0000 (04:31 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 29 Oct 2020 08:07:02 +0000 (09:07 +0100)
commita4c597c385c474e07c672afa8b4406f10b595539
tree59bb2e0361802f768a648c82d4318955f1d6a5a1
parent47aa0f3cf46c5b0087461317f3870aca162cb137
media: s5p-mfc: Fix a reference count leak

[ Upstream commit 78741ce98c2e36188e2343434406b0e0bc50b0e7 ]

pm_runtime_get_sync() increments the runtime PM usage counter even
when it returns an error code, causing incorrect ref count if
pm_runtime_put_noidle() is not called in error handling paths.
Thus call pm_runtime_put_noidle() if pm_runtime_get_sync() fails.

Fixes: c5086f130a77 ("[media] s5p-mfc: Use clock gating only on MFC v5 hardware")
Signed-off-by: Qiushi Wu <wu000273@umn.edu>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/media/platform/s5p-mfc/s5p_mfc_pm.c