[SCSI] enclosure: fix WARN_ON in dual path device removing
authorJames Bottomley <JBottomley@Parallels.com>
Fri, 15 Nov 2013 22:58:00 +0000 (14:58 -0800)
committerJames Bottomley <JBottomley@Parallels.com>
Mon, 2 Dec 2013 19:13:14 +0000 (11:13 -0800)
commita1470c7bf3a4676e62e4c0fb204e339399eb5c59
tree5678d07f70cadae7509067b2118a956400d41ff8
parent6cd60b37f72b2d15b8983431546af50b7064935d
[SCSI] enclosure: fix WARN_ON in dual path device removing

Bug report from: wenxiong@linux.vnet.ibm.com

The issue is happened in dual controller configuration. We got the
sysfs warnings when rmmod the ipr module.

enclosure_unregister() in drivers/msic/enclosure.c, call device_unregister()
for each componment deivce, device_unregister() ->device_del()->kobject_del()
->sysfs_remove_dir(). In sysfs_remove_dir(), set kobj->sd = NULL.

For each componment device,
enclosure_component_release()->enclosure_remove_links()->sysfs_remove_link()
in which checking kobj->sd again, it has been set as NULL when doing
device_unregister. So we saw all these sysfs WARNING.

Tested-by: wenxiong@linux.vnet.ibm.com
Cc: stable@vger.kernel.org
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
drivers/misc/enclosure.c