NFSv4/pNFS: Fix another issue with a list iterator pointing to the head
authorTrond Myklebust <trond.myklebust@hammerspace.com>
Mon, 28 Mar 2022 12:36:34 +0000 (08:36 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 20 Apr 2022 07:08:21 +0000 (09:08 +0200)
commit9b54b4d062d343b1d2351d5d1205df8d339aff94
tree8b229a0c12eedb50e70e41bdec33689a03c5bcc3
parent858642789ada1b48630f322e59416ca9fca3e6b7
NFSv4/pNFS: Fix another issue with a list iterator pointing to the head

[ Upstream commit 7c9d845f0612e5bcd23456a2ec43be8ac43458f1 ]

In nfs4_callback_devicenotify(), if we don't find a matching entry for
the deviceid, we're left with a pointer to 'struct nfs_server' that
actually points to the list of super blocks associated with our struct
nfs_client.
Furthermore, even if we have a valid pointer, nothing pins the super
block, and so the struct nfs_server could end up getting freed while
we're using it.

Since all we want is a pointer to the struct pnfs_layoutdriver_type,
let's skip all the iteration over super blocks, and just use APIs to
find the layout driver directly.

Reported-by: Xiaomeng Tong <xiam0nd.tong@gmail.com>
Fixes: 1be5683b03a7 ("pnfs: CB_NOTIFY_DEVICEID")
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/nfs/callback_proc.c
fs/nfs/pnfs.c
fs/nfs/pnfs.h