projects / GitHub / moto-9609 / android_kernel_motorola_exynos9610.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 4cfc86f) | patch
macb: fix PHY reset
authorSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Tue, 22 Mar 2016 19:27:38 +0000 (22:27 +0300)
committerDavid S. Miller <davem@davemloft.net>
Tue, 22 Mar 2016 20:07:07 +0000 (16:07 -0400)
commit9a0384c020b055a555500906be8ac314c92f3998
tree2b4c2225e9d9b853033a17708bad40433902c69ftree | snapshot (tar.gz zip)
parent4cfc86f3dae6ca38ed49cdd78f458a03d4d87992commit | diff
macb: fix PHY reset

The driver calls gpiod_set_value() with GPIOD_OUT_* instead of 0 and 1, as
a result the PHY isn't really  put back into reset state in macb_remove().
Moreover, the driver assumes that something else has set the GPIO direction
to output, so if  it has not, the PHY may not be taken out of reset in
macb_probe() either...

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/cadence/macb.c diff | blob | blame | history