Regulator: lp3972 cleanup
authorAxel Lin <axel.lin@gmail.com>
Sat, 18 Sep 2010 05:13:28 +0000 (13:13 +0800)
committerLiam Girdwood <lrg@slimlogic.co.uk>
Thu, 28 Oct 2010 21:40:31 +0000 (22:40 +0100)
commit993af7c048f414121bc81e0d6e69456e3862a06b
tree26b8990dddfbd056d95b2ac0458af0103ed080c4
parent5976f0959d5251ae5b4db848eaa2f42a19e98652
Regulator: lp3972 cleanup

This patch includes below fixes based on Mark's comment.
 - Return actual error if i2c_smbus_read_byte_data() fail
 - Add spaces around bitwise AND operator(&) to improve readability
 - Add comment to explain why we need to update voltage change control register
   for LDO1 and LDO5
 - Logging the value for diagnostics if chip reported incorrect voltage value
 - Add __devinit annotation for setup_regulators()
 - Show system control register1 value if the value is mismatched
 - Logging the value for diagnostics if failed to detect device

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Liam Girdwood <lrg@slimlogic.co.uk>
drivers/regulator/lp3972.c