nvme: avoid to use blk_mq_abort_requeue_list()
authorMing Lei <ming.lei@redhat.com>
Mon, 22 May 2017 15:05:04 +0000 (23:05 +0800)
committerChristoph Hellwig <hch@lst.de>
Mon, 22 May 2017 18:50:10 +0000 (20:50 +0200)
commit986f75c876dbafed98eba7cb516c5118f155db23
tree9fc4ac2dfe1c3fc6b5fa38fd7886db0d0cf68f06
parent806f026f9b901eaf1a6baeb48b5da18d6a4f818e
nvme: avoid to use blk_mq_abort_requeue_list()

NVMe may add request into requeue list simply and not kick off the
requeue if hw queues are stopped. Then blk_mq_abort_requeue_list()
is called in both nvme_kill_queues() and nvme_ns_remove() for
dealing with this issue.

Unfortunately blk_mq_abort_requeue_list() is absolutely a
race maker, for example, one request may be requeued during
the aborting. So this patch just calls blk_mq_kick_requeue_list() in
nvme_kill_queues() to handle this issue like what nvme_start_queues()
does. Now all requests in requeue list when queues are stopped will be
handled by blk_mq_kick_requeue_list() when queues are restarted, either
in nvme_start_queues() or in nvme_kill_queues().

Cc: stable@vger.kernel.org
Reported-by: Zhang Yi <yizhan@redhat.com>
Reviewed-by: Keith Busch <keith.busch@intel.com>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/nvme/host/core.c