atmel-lcdc: fix pixclock upper bound detection
authorBen Nizette <bn@niasdigital.com>
Tue, 16 Jun 2009 22:34:24 +0000 (15:34 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Wed, 17 Jun 2009 02:47:58 +0000 (19:47 -0700)
commit97b9a5a28b5fd02ceb3fcccee05e39dd62e4f474
tree4f015ebdf8662960a115d666fe0d9ba65de0fb3e
parent4113819eb360555a91a8291f37bbbe9d26c5b275
atmel-lcdc: fix pixclock upper bound detection

AFAICT the code which checks that the requested pixclock value is within
bounds is incorrect.  It ensures that the lcdc core clock is at least
(bytes per pixel) times higher than the pixel clock rather than just
greater than or equal to.

There are tighter restrictions on the pixclock value as a function of bus
width for STN panels but even then it isn't a simple relationship as
currently checked for.  IMO either something like the below patch should
be applied or else more detailed checking logic should be implemented
which takes in to account the panel type as well.

Signed-off-by: Ben Nizette <bn@niasdigital.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
Cc: Daniel Glockner <dg@emlix.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/video/atmel_lcdfb.c