[SCSI] libiscsi: regression: fix header digest errors
authorMike Christie <michaelc@cs.wisc.edu>
Sat, 24 Apr 2010 21:21:19 +0000 (16:21 -0500)
committerJames Bottomley <James.Bottomley@suse.de>
Sun, 2 May 2010 15:16:50 +0000 (11:16 -0400)
commit96b1f96dcab87756c0a1e7ba76bc5dc2add82b88
tree9625a785d543663ba4a97e7fc452a9d77af9a86d
parent70b25f890ce9f0520c64075ce9225a5b020a513e
[SCSI] libiscsi: regression: fix header digest errors

This fixes a regression introduced with this commit:

commit d3305f3407fa3e9452079ec6cc8379067456e4aa
Author: Mike Christie <michaelc@cs.wisc.edu>
Date:   Thu Aug 20 15:10:58 2009 -0500

    [SCSI] libiscsi: don't increment cmdsn if cmd is not sent

in 2.6.32.

When I moved the hdr->cmdsn after init_task, I added
a bug when header digests are used. The problem is
that the LLD may calculate the header digest in init_task,
so if we then set the cmdsn after the init_task call we
change what the digest will be calculated by the target.

Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
Cc: Stable Tree <stable@kernel.org>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
drivers/scsi/libiscsi.c