cgroup: make sure that decisions in __css_put are atomic
authorSalman Qazi <sqazi@google.com>
Thu, 7 Jun 2012 01:51:35 +0000 (18:51 -0700)
committerTejun Heo <tj@kernel.org>
Thu, 7 Jun 2012 01:51:35 +0000 (18:51 -0700)
commit967db0ea65b0bf8507a7643ac8f296c4f2c0a834
tree143a9493c9a81db130b313c0c46d87a909485541
parent71fae7e714749a52cb8be777ec014f82e8a747f4
cgroup: make sure that decisions in __css_put are atomic

__css_put is using atomic_dec on the ref count, and then
looking at the ref count to make decisions.  This is prone
to races, as someone else may decrement ref count between
our decrement and our decision.  Instead, we should base our
decisions on the value that we decremented the ref count to.

(This results in an actual race on Google's kernel which I
haven't been able to reproduce on the upstream kernel.  Having
said that, it's still incorrect by inspection).

Signed-off-by: Salman Qazi <sqazi@google.com>
Acked-by: Li Zefan <lizefan@huawei.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: stable@vger.kernel.org
kernel/cgroup.c