of: add helper to lookup compatible child node
authorJohan Hovold <johan@kernel.org>
Mon, 27 Aug 2018 08:21:45 +0000 (10:21 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 1 Dec 2018 08:44:21 +0000 (09:44 +0100)
commit95cd1aacf9cea9b9ec86a24493a021e08356b5d0
tree2afe7ea0f5a7c53cf2ab547ee6852ce749cb6829
parentd77eacdb1e30fbed315c2e09ba7a4e919d5f3348
of: add helper to lookup compatible child node

[ Upstream commit 36156f9241cb0f9e37d998052873ca7501ad4b36 ]

Add of_get_compatible_child() helper that can be used to lookup
compatible child nodes.

Several drivers currently use of_find_compatible_node() to lookup child
nodes while failing to notice that the of_find_ functions search the
entire tree depth-first (from a given start node) and therefore can
match unrelated nodes. The fact that these functions also drop a
reference to the node they start searching from (e.g. the parent node)
is typically also overlooked, something which can lead to use-after-free
bugs.

Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Rob Herring <robh@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/of/base.c
include/linux/of.h