drm/msm: Fix fbdev for 16- and 24-bit modes.
authorDaniel Thompson <daniel.thompson@linaro.org>
Fri, 17 Oct 2014 15:48:54 +0000 (16:48 +0100)
committerRob Clark <robdclark@gmail.com>
Sun, 16 Nov 2014 19:22:43 +0000 (14:22 -0500)
commit95a9b8d10cb0ee78c1eb81ea51eeaf94be479416
tree2cd44247d662922cd750dafa297995e609ce82b6
parent77a147e742afe33a612d93d61ba153df668de428
drm/msm: Fix fbdev for 16- and 24-bit modes.

Currently forcing the video mode from the kernel command line (for example
video=HDMI-A-1:1280x720-16@60) does not correctly set the number of bits
per pixel. This is due to a rather aggressive override in
msm_fbdev_create(). This is a particular problem for Android bring up
because the software EGL fallbacks don't support 32bpp.

Since the overrides are actually the default values anyway then this
problem can be trivially fixed by removing the overrides completely.

Change was tested by dd'ing a test image to /dev/fb0 with no video=
(still 32bpp), video=1920x1080-32@60, video=1920x1080-24@60 and
video=1920x1080-16@60 .

Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
Cc: David Airlie <airlied@linux.ie>
Cc: Rob Clark <robdclark@gmail.com>
Signed-off-by: Rob Clark <robdclark@gmail.com>
drivers/gpu/drm/msm/msm_fbdev.c