ARM: fix PTRACE_SETVFPREGS on SMP systems
authorRussell King <rmk+kernel@armlinux.org.uk>
Mon, 30 May 2016 22:14:56 +0000 (23:14 +0100)
committerWilly Tarreau <w@1wt.eu>
Mon, 22 Aug 2016 05:31:39 +0000 (07:31 +0200)
commit951b391d266e93a56559d28817663a10128e0159
tree62b42e9f26c0852d4b9811caddef7c470d2ef4c4
parent42bc57b6a75b5242f2103b368be0693fecf292d2
ARM: fix PTRACE_SETVFPREGS on SMP systems

commit e2dfb4b880146bfd4b6aa8e138c0205407cebbaf upstream.

PTRACE_SETVFPREGS fails to properly mark the VFP register set to be
reloaded, because it undoes one of the effects of vfp_flush_hwstate().

Specifically vfp_flush_hwstate() sets thread->vfpstate.hard.cpu to
an invalid CPU number, but vfp_set() overwrites this with the original
CPU number, thereby rendering the hardware state as apparently "valid",
even though the software state is more recent.

Fix this by reverting the previous change.

Cc: <stable@vger.kernel.org>
Fixes: 8130b9d7b9d8 ("ARM: 7308/1: vfp: flush thread hwstate before copying ptrace registers")
Acked-by: Will Deacon <will.deacon@arm.com>
Tested-by: Simon Marchi <simon.marchi@ericsson.com>
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Signed-off-by: Willy Tarreau <w@1wt.eu>
arch/arm/kernel/ptrace.c