eCryptfs: Remove buggy and unnecessary write in file name decode routine
authorMichael Halcrow <mhalcrow@google.com>
Wed, 26 Nov 2014 17:09:16 +0000 (09:09 -0800)
committerTyler Hicks <tyhicks@canonical.com>
Wed, 26 Nov 2014 21:55:02 +0000 (15:55 -0600)
commit942080643bce061c3dd9d5718d3b745dcb39a8bc
treeec9054a49cb18eb8692fb3360686b80586d70357
parent831115af5ca36d713355bf1b379081691eca8b3f
eCryptfs: Remove buggy and unnecessary write in file name decode routine

Dmitry Chernenkov used KASAN to discover that eCryptfs writes past the
end of the allocated buffer during encrypted filename decoding. This
fix corrects the issue by getting rid of the unnecessary 0 write when
the current bit offset is 2.

Signed-off-by: Michael Halcrow <mhalcrow@google.com>
Reported-by: Dmitry Chernenkov <dmitryc@google.com>
Suggested-by: Kees Cook <keescook@chromium.org>
Cc: stable@vger.kernel.org # v2.6.29+: 51ca58d eCryptfs: Filename Encryption: Encoding and encryption functions
Signed-off-by: Tyler Hicks <tyhicks@canonical.com>
fs/ecryptfs/crypto.c