ext4: fix EXT_MAX_EXTENT/INDEX to check for zeroed eh_max
authorHarshad Shirwadkar <harshadshirwadkar@gmail.com>
Tue, 21 Apr 2020 02:39:59 +0000 (19:39 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 20 Jun 2020 08:25:15 +0000 (10:25 +0200)
commit928c796ffdd0e314353bf1ff604c82799d98ea55
treed0efc6f09e209e94f478f66b5755021274685d28
parent8464622583fc9728bffeaa7f0b21f57d39e56308
ext4: fix EXT_MAX_EXTENT/INDEX to check for zeroed eh_max

commit c36a71b4e35ab35340facdd6964a00956b9fef0a upstream.

If eh->eh_max is 0, EXT_MAX_EXTENT/INDEX would evaluate to unsigned
(-1) resulting in illegal memory accesses. Although there is no
consistent repro, we see that generic/019 sometimes crashes because of
this bug.

Ran gce-xfstests smoke and verified that there were no regressions.

Signed-off-by: Harshad Shirwadkar <harshadshirwadkar@gmail.com>
Link: https://lore.kernel.org/r/20200421023959.20879-2-harshadshirwadkar@gmail.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/ext4/ext4_extents.h