[RAMEN9610-22013]HID: make arrays usage and value to be the same
authorWill McVicker <willmcvicker@google.com>
Sat, 5 Dec 2020 00:48:48 +0000 (00:48 +0000)
committerlingsen2 <lingsen2@lenovo.com>
Thu, 3 Jun 2021 02:19:03 +0000 (10:19 +0800)
commit924d5dacc39ba20da7c7cba35e24a95fcecb74e7
treea14dcf6418a22eff3e2f0ed0977345e49868cae1
parentffa580eb04df28a6061e2d67fe60c00497dfc39d
[RAMEN9610-22013]HID: make arrays usage and value to be the same

commit ed9be64eefe26d7d8b0b5b9fa3ffdf425d87a01f upstream.

The HID subsystem allows an "HID report field" to have a different
number of "values" and "usages" when it is allocated. When a field
struct is created, the size of the usage array is guaranteed to be at
least as large as the values array, but it may be larger. This leads to
a potential out-of-bounds write in
__hidinput_change_resolution_multipliers() and an out-of-bounds read in
hidinput_count_leds().

To fix this, let's make sure that both the usage and value arrays are
the same size.

Change-Id: I96857aa2e17b88d900a50aa16a016f4aca6b1fa5
Cc: stable@vger.kernel.org
Signed-off-by: Will McVicker <willmcvicker@google.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/hid/hid-core.c