x86/asm/decoder: Fix and enforce max instruction size in the insn decoder
authorAndy Lutomirski <luto@amacapital.net>
Wed, 28 Jan 2015 00:06:02 +0000 (16:06 -0800)
committerIngo Molnar <mingo@kernel.org>
Wed, 18 Feb 2015 23:01:24 +0000 (00:01 +0100)
commit91e5ed49fca09c2b83b262b9757d1376ee2b46c3
tree494a1ca21a9743ec5d13b918938cc99d4ede7115
parentcbb53b9623a70f012e1fdfb6fc0af6878df4762b
x86/asm/decoder: Fix and enforce max instruction size in the insn decoder

x86 instructions cannot exceed 15 bytes, and the instruction
decoder should enforce that.  Prior to 6ba48ff46f76, the
instruction length limit was implicitly set to 16, which was an
approximation of 15, but there is currently no limit at all.

Fix MAX_INSN_SIZE (it should be 15, not 16), and fix the decoder
to reject instructions that exceed MAX_INSN_SIZE.

Other than potentially confusing some of the decoder sanity
checks, I'm not aware of any actual problems that omitting this
check would cause, nor am I aware of any practical problems
caused by the MAX_INSN_SIZE error.

Signed-off-by: Andy Lutomirski <luto@amacapital.net>
Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Fixes: 6ba48ff46f76 ("x86: Remove arbitrary instruction size limit ...
Link: http://lkml.kernel.org/r/f8f0bc9b8c58cfd6830f7d88400bf1396cbdcd0f.1422403511.git.luto@amacapital.net
Signed-off-by: Ingo Molnar <mingo@kernel.org>
arch/x86/include/asm/insn.h
arch/x86/lib/insn.c