ext4: fix del_timer() misuse for ->s_err_report
authorAl Viro <viro@ZenIV.linux.org.uk>
Mon, 9 Dec 2013 01:52:31 +0000 (20:52 -0500)
committerTheodore Ts'o <tytso@mit.edu>
Mon, 9 Dec 2013 01:52:31 +0000 (20:52 -0500)
commit9105bb149bbbc555d2e11ba5166dfe7a24eae09e
tree39be8d3d708388d52fcae98dd307a60194cc03f8
parent5946d089379a35dda0e531710b48fca05446a196
ext4: fix del_timer() misuse for ->s_err_report

That thing should be del_timer_sync(); consider what happens
if ext4_put_super() call of del_timer() happens to come just as it's
getting run on another CPU.  Since that timer reschedules itself
to run next day, you are pretty much guaranteed that you'll end up
with kfree'd scheduled timer, with usual fun consequences.  AFAICS,
that's -stable fodder all way back to 2010... [the second del_timer_sync()
is almost certainly not needed, but it doesn't hurt either]

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: stable@vger.kernel.org
fs/ext4/super.c