netfilter: remove unnecessary goto statement for error recovery
authorJean Sacren <sakiwit@gmail.com>
Sun, 19 Aug 2012 15:11:32 +0000 (15:11 +0000)
committerPablo Neira Ayuso <pablo@netfilter.org>
Wed, 22 Aug 2012 17:17:38 +0000 (19:17 +0200)
commit90efbed18a30d78145419cdbd44f9ec152efeb16
tree8724b522e0b6152856baad0a407573a917bbf6da
parent6705e86724f1ac83394592be7dbfc0c07ac25aa2
netfilter: remove unnecessary goto statement for error recovery

Usually it's a good practice to use goto statement for error recovery
when initializing the module. This approach could be an overkill if:

 1) there is only one fail case;
 2) success and failure use the same return statement.

For a cleaner approach, remove the unnecessary goto statement and
directly implement error recovery.

Signed-off-by: Jean Sacren <sakiwit@gmail.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/ipv4/netfilter/iptable_filter.c
net/ipv4/netfilter/iptable_mangle.c
net/ipv4/netfilter/iptable_raw.c