scripts/dtc: Remove redundant YYLOC global declaration
authorDirk Mueller <dmueller@suse.com>
Tue, 14 Jan 2020 17:53:41 +0000 (18:53 +0100)
committerivanmeler <i_ivan@windowslive.com>
Fri, 8 Oct 2021 11:41:59 +0000 (11:41 +0000)
commit90ef7bfc89c6195f9598be4bc35b2d3072008dbd
tree2b25db2a6a7c44ffacbffd735a167ee9ae93470e
parentb44930e0c744845d8e243cd20d29b147e1e74f07
scripts/dtc: Remove redundant YYLOC global declaration

gcc 10 will default to -fno-common, which causes this error at link
time:

  (.text+0x0): multiple definition of `yylloc'; dtc-lexer.lex.o (symbol from plugin):(.text+0x0): first defined here

This is because both dtc-lexer as well as dtc-parser define the same
global symbol yyloc. Before with -fcommon those were merged into one
defintion. The proper solution would be to to mark this as "extern",
however that leads to:

  dtc-lexer.l:26:16: error: redundant redeclaration of 'yylloc' [-Werror=redundant-decls]
   26 | extern YYLTYPE yylloc;
      |                ^~~~~~
In file included from dtc-lexer.l:24:
dtc-parser.tab.h:127:16: note: previous declaration of 'yylloc' was here
  127 | extern YYLTYPE yylloc;
      |                ^~~~~~
cc1: all warnings being treated as errors

which means the declaration is completely redundant and can just be
dropped.

Signed-off-by: Dirk Mueller <dmueller@suse.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
[robh: cherry-pick from upstream]
Cc: stable@vger.kernel.org
Signed-off-by: Rob Herring <robh@kernel.org>
Change-Id: Ie5f32479b6fb948472bbfdec45a07c3728855c28
Signed-off-by: SamarV-121 <samarvispute121@pm.me>
scripts/dtc/dtc-lexer.l
scripts/dtc/dtc-lexer.lex.c_shipped