[DLM] saved dlm message can be dropped
authorDavid Teigland <teigland@redhat.com>
Wed, 24 Jan 2007 16:11:45 +0000 (10:11 -0600)
committerSteven Whitehouse <swhiteho@redhat.com>
Mon, 5 Feb 2007 18:37:47 +0000 (13:37 -0500)
commit8fd3a98f2c22982aff4d29e4ee72959d3032c123
tree9d4b75dc24d506572d7f2700f0d68f568969e62d
parentf1f1c1ccf7848a6e25db30ee9216e1a1e7eb6bef
[DLM] saved dlm message can be dropped

dlm_receive_message() returns 0 instead of returning 'error'.  What would
happen is that process_requestqueue would take a saved message off the
requestqueue and call receive_message on it.  receive_message would then
see that recovery had been aborted, set error to EINTR, and 'goto out',
expecting that the error would be returned.  Instead, 0 was always
returned, so process_requestqueue would think that the message had been
processed and delete it instead of saving it to process next time.  This
means the message (usually an unlock in my tests) would be lost.

Signed-off-by: David Teigland <teigland@redhat.com>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
fs/dlm/lock.c