perf tui: Change default selection background color to yellow
authorIngo Molnar <mingo@kernel.org>
Thu, 5 Mar 2015 10:32:13 +0000 (11:32 +0100)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Wed, 9 Dec 2015 16:41:55 +0000 (13:41 -0300)
commit8d7d377c2bea16afa6b600a4517615a9eebb259b
tree77d0eb846f0ec9c10f826b42fbc6f2fbede3164a
parenta30c99a0beb3030ba42dab38cad6273cd090805d
perf tui: Change default selection background color to yellow

Boris reported that 'perf top' is unusable on his default 'black on
white' terminal, which uses (eye friendly) light-grey as a background
color.

The reason is that the TUI cursor for the current selection line uses
HE_COLORSET_SELECTED, and that has a default background color of
'lightgrey' - which is a common terminal background choice and thus
the colors conflict.

Use yellow as the background color instead: that should be an uncommon
terminal background, yet it's still ergonomic on both black and
white/grey terminals.

[ It would be a better solution to straight out detect color
  collisions and resolve them reasonably by converting them to RGB and
  calculating color space distances, but I was unable to find
  proper documentation for SLtt_get_color_object() to recover the
  current color scheme so I gave up ... Yellow works well enough. ]

Reported-and-Tested-by: Borislav Petkov <bp@alien8.de>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: David Binderman <dcb314@hotmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/20150305103213.GA23046@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/ui/browser.c