ARM: 8357/1: perf: fix memory leak when probing PMU PPIs
authorWill Deacon <will.deacon@arm.com>
Thu, 14 May 2015 17:07:44 +0000 (18:07 +0100)
committerRussell King <rmk+kernel@arm.linux.org.uk>
Mon, 18 May 2015 20:51:28 +0000 (21:51 +0100)
commit8d2812849acbc13c07bdad8a0a55a342ec1ce3a4
tree5d16f21c6dad3e360ecc303ed2d9772fdc1ea4d8
parent1b97937246d8b97c0760d16d8992c7937bdf5e6a
ARM: 8357/1: perf: fix memory leak when probing PMU PPIs

Commit 338d9dd3e2ae ("ARM: 8351/1: perf: don't warn about missing
interrupt-affinity property for PPIs") added a check for PPIs so that
we avoid parsing the interrupt-affinity property for these naturally
affine interrupts.

Unfortunately, this check can trigger an early (successful) return and
we will leak the irqs array. This patch fixes the issue by reordering
the code so that the check is performed before any independent
allocation.

Reported-by: David Binderman <dcb314@hotmail.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
arch/arm/kernel/perf_event_cpu.c