cgroup: make sure a parent css isn't freed before its children
authorTejun Heo <tj@kernel.org>
Thu, 21 Jan 2016 20:32:15 +0000 (15:32 -0500)
committerTejun Heo <tj@kernel.org>
Fri, 22 Jan 2016 15:42:58 +0000 (10:42 -0500)
commit8bb5ef79bc0f4016ecf79e8dce6096a3c63603e4
tree3a2129fd05443c134b033fd476f93ca0faf28b01
parentaa226ff4a1ce79f229c6b7a4c0a14e17fececd01
cgroup: make sure a parent css isn't freed before its children

There are three subsystem callbacks in css shutdown path -
css_offline(), css_released() and css_free().  Except for
css_released(), cgroup core didn't guarantee the order of invocation.
css_offline() or css_free() could be called on a parent css before its
children.  This behavior is unexpected and led to bugs in cpu and
memory controller.

The previous patch updated ordering for css_offline() which fixes the
cpu controller issue.  While there currently isn't a known bug caused
by misordering of css_free() invocations, let's fix it too for
consistency.

css_free() ordering can be trivially fixed by moving putting of the
parent css below css_free() invocation.

Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
kernel/cgroup.c