ipv6: Fix Smatch warning.
authorLi Wei <lw@cn.fujitsu.com>
Wed, 7 Mar 2012 14:58:07 +0000 (14:58 +0000)
committerDavid S. Miller <davem@davemloft.net>
Sun, 11 Mar 2012 22:57:11 +0000 (15:57 -0700)
commit8b2aaedee4eaa94e816144ed54b9707b96be29f8
tree0fd46f2b7fdfd5aacda2c35470048dfe2fb00dab
parent7fbc415d7bd0ff0224eea53c678fa9f13f646b4f
ipv6: Fix Smatch warning.

With commit d6ddef9e641d(IPv6: Fix not join all-router mcast group
when forwarding set.) I check 'dev' after it's dereference that
leads to a Smatch complaint:

net/ipv6/addrconf.c:438 ipv6_add_dev()
 warn: variable dereferenced before check 'dev' (see line 432)

net/ipv6/addrconf.c
   431 /* protected by rtnl_lock */
   432 rcu_assign_pointer(dev->ip6_ptr, ndev);
                                   ^^^^^^^^^^^^
Old dereference.

   433
   434 /* Join all-node multicast group */
   435 ipv6_dev_mc_inc(dev, &in6addr_linklocal_allnodes);
   436
   437 /* Join all-router multicast group if forwarding is set
*/
   438 if (ndev->cnf.forwarding && dev && (dev->flags &
IFF_MULTICAST))
                                            ^^^

Remove the check to avoid the complaint as 'dev' can't be NULL.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Li Wei <lw@cn.fujitsu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv6/addrconf.c