[SCSI] aacraid: Eliminate use after free
authorJulia Lawall <julia@diku.dk>
Sat, 15 May 2010 09:46:12 +0000 (11:46 +0200)
committerJames Bottomley <James.Bottomley@suse.de>
Tue, 25 May 2010 15:59:07 +0000 (10:59 -0500)
commit8a52da632ceb9d8b776494563df579e87b7b586b
tree77f7e2dff5622589749cbbcfec8edb83006c5cab
parent36b83ded062a7416bb9184f4d6c537ad99571f4d
[SCSI] aacraid: Eliminate use after free

The debugging code using the freed structure is moved before the kfree.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@free@
expression E;
position p;
@@
kfree@p(E)

@@
expression free.E, subE<=free.E, E1;
position free.p;
@@

  kfree@p(E)
  ...
(
  subE = E1
|
* E
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
drivers/scsi/aacraid/commctrl.c