staging: unisys: refactor create_device()
authorBenjamin Romer <benjamin.romer@unisys.com>
Fri, 5 Dec 2014 22:08:55 +0000 (17:08 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 10 Jan 2015 01:32:33 +0000 (17:32 -0800)
commit8a05beb1156ac5b1c8dc8c1df9756b279ebe2a22
treea38056134dc3bf70c074a76bd8dcf04a262f23e4
parente6c15b7b1f089700d0c2a664d6442fa97760ad3a
staging: unisys: refactor create_device()

OK, lets clean up this messy function. The entire thing is reflowed so spacing
and indentation is correct. Tests that created extra indentation were swapped
for equivalent negative tests that did not create extra indentation. Use of
cmp_uuid_le() were fixed to test specifically for the zero case, and not to
lazily use !cmp_uuid_le(). CamelCase local variable names were fixed:

busNo => bus_no
devNo => dev_no
minSize => min_size
pReqHandler => req_handler
Away => cleanup

Finally, the struct guest_msgs cmd declaration was moved to the beginning of
the function, and cringing and wincing at the function was significantly
reduced.

Signed-off-by: Bryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/unisys/uislib/uislib.c