KVM: x86: fix wbinvd_dirty_mask use-after-free
authorIdo Yariv <ido@wizery.com>
Fri, 21 Oct 2016 16:39:57 +0000 (12:39 -0400)
committerDanny Wood <danwood76@gmail.com>
Tue, 29 Jan 2019 13:14:11 +0000 (13:14 +0000)
commit895c17353533eaca98aedee07f8905e9ab2a2418
treeeccf5530f6f3a5bfdc968779a5a4a37b18493890
parent3de7981b39ba063fe3d95c34c1cab0a676e08b69
KVM: x86: fix wbinvd_dirty_mask use-after-free

commit bd768e146624cbec7122ed15dead8daa137d909d upstream.

vcpu->arch.wbinvd_dirty_mask may still be used after freeing it,
corrupting memory. For example, the following call trace may set a bit
in an already freed cpu mask:
    kvm_arch_vcpu_load
    vcpu_load
    vmx_free_vcpu_nested
    vmx_free_vcpu
    kvm_arch_vcpu_free

Fix this by deferring freeing of wbinvd_dirty_mask.

Signed-off-by: Ido Yariv <ido@wizery.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Radim KrÄ\8dmáÅ\99 <rkrcmar@redhat.com>
Signed-off-by: Willy Tarreau <w@1wt.eu>
arch/x86/kvm/x86.c