xfs: bad assertion for delalloc an extent that start at i_size
authorZorro Lang <zlang@redhat.com>
Mon, 15 May 2017 15:40:02 +0000 (08:40 -0700)
committerDarrick J. Wong <darrick.wong@oracle.com>
Tue, 16 May 2017 16:24:36 +0000 (09:24 -0700)
commit892d2a5f705723b2cb488bfb38bcbdcf83273184
treef42195bfd607a5c60cf4a67dbc4954b65dd673fe
parent6e747506dde195d3d05fe2bb8ef78aceba28a5e3
xfs: bad assertion for delalloc an extent that start at i_size

By run fsstress long enough time enough in RHEL-7, I find an
assertion failure (harder to reproduce on linux-4.11, but problem
is still there):

  XFS: Assertion failed: (iflags & BMV_IF_DELALLOC) != 0, file: fs/xfs/xfs_bmap_util.c

The assertion is in xfs_getbmap() funciton:

  if (map[i].br_startblock == DELAYSTARTBLOCK &&
-->   map[i].br_startoff <= XFS_B_TO_FSB(mp, XFS_ISIZE(ip)))
          ASSERT((iflags & BMV_IF_DELALLOC) != 0);

When map[i].br_startoff == XFS_B_TO_FSB(mp, XFS_ISIZE(ip)), the
startoff is just at EOF. But we only need to make sure delalloc
extents that are within EOF, not include EOF.

Signed-off-by: Zorro Lang <zlang@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
fs/xfs/xfs_bmap_util.c