projects / GitHub / LineageOS / android_kernel_motorola_exynos9610.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 9902e68) | patch
libceph: fixup error handling in osdmap_apply_incremental()
authorIlya Dryomov <ilya.dryomov@inktank.com>
Thu, 13 Mar 2014 14:36:15 +0000 (16:36 +0200)
committerSage Weil <sage@inktank.com>
Sat, 5 Apr 2014 04:07:44 +0000 (21:07 -0700)
commit86f1742b94dd0b4a2eb9255205d1756ddea182f8
tree3ac1c58709b0aba00d2acb15ef17bc49ff630cf8tree | snapshot (tar.gz zip)
parent9902e682c7f3df9ed5f60bc6f9c7efa6fd6b2d1dcommit | diff
libceph: fixup error handling in osdmap_apply_incremental()

The existing error handling scheme requires resetting err to -EINVAL
prior to calling any ceph_decode_* macro.  This is ugly and fragile,
and there already are a few places where we would return 0 on error,
due to a missing reset.  Follow osdmap_decode() and fix this by adding
a special e_inval label to be used by all ceph_decode_* macros.

Signed-off-by: Ilya Dryomov <ilya.dryomov@inktank.com>
Reviewed-by: Alex Elder <elder@linaro.org>
net/ceph/osdmap.c diff | blob | blame | history