xfrm_user: return error pointer instead of NULL
authorMathias Krause <minipli@googlemail.com>
Thu, 13 Sep 2012 11:41:26 +0000 (11:41 +0000)
committerDavid S. Miller <davem@davemloft.net>
Tue, 18 Sep 2012 20:13:45 +0000 (16:13 -0400)
commit864745d291b5ba80ea0bd0edcbe67273de368836
tree3a1f7ea5641d94680f30514c88b4996e736926bc
parent2c20cbd7e3aa6e9dddc07975d3f3a89fe1f69c00
xfrm_user: return error pointer instead of NULL

When dump_one_state() returns an error, e.g. because of a too small
buffer to dump the whole xfrm state, xfrm_state_netlink() returns NULL
instead of an error pointer. But its callers expect an error pointer
and therefore continue to operate on a NULL skbuff.

This could lead to a privilege escalation (execution of user code in
kernel context) if the attacker has CAP_NET_ADMIN and is able to map
address 0.

Signed-off-by: Mathias Krause <minipli@googlemail.com>
Acked-by: Steffen Klassert <steffen.klassert@secunet.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/xfrm/xfrm_user.c