sound: rawmidi: fix double init when opening MIDI device with O_APPEND
authorClemens Ladisch <clemens@ladisch.de>
Wed, 21 Oct 2009 07:09:38 +0000 (09:09 +0200)
committerTakashi Iwai <tiwai@suse.de>
Tue, 10 Nov 2009 15:20:43 +0000 (16:20 +0100)
commit8579d2d7779d7ff41ea2a0183015e0e5038f1043
treea194af444f11846d078ca3fb87bdb61f5188464e
parentdede17b8e931eeaa38b0288e8d545d558d904942
sound: rawmidi: fix double init when opening MIDI device with O_APPEND

Commit 9a1b64caac82aa02cb74587ffc798e6f42c6170a in 2.6.30 moved the
substream initialization code to where it would be executed every time
the substream is opened.

This had the consequence that any further opening would drop and leak
the data in the existing buffer, and that the device driver's open
callback would be called multiple times, unexpectedly.

Signed-off-by: Clemens Ladisch <clemens@ladisch.de>
Cc: <stable@kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/core/rawmidi.c