ARM: findbit: fix overflowing offset
authorRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Tue, 26 Jul 2022 22:51:48 +0000 (23:51 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 25 Aug 2022 09:11:15 +0000 (11:11 +0200)
commit853d0d96e44d07e757de7012ddc4bb957ee4cd16
tree07a586dc7d3d37cfe1cdb2e14830fd9b2e358571
parent2dabe6a872a5744865372eb30ea51e8ccd21305a
ARM: findbit: fix overflowing offset

[ Upstream commit ec85bd369fd2bfaed6f45dd678706429d4f75b48 ]

When offset is larger than the size of the bit array, we should not
attempt to access the array as we can perform an access beyond the
end of the array. Fix this by changing the pre-condition.

Using "cmp r2, r1; bhs ..." covers us for the size == 0 case, since
this will always take the branch when r1 is zero, irrespective of
the value of r2. This means we can fix this bug without adding any
additional code!

Tested-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/arm/lib/findbit.S