powerpc/perf: Fix ABIv2 kernel backtraces
authorAnton Blanchard <anton@samba.org>
Tue, 26 Aug 2014 02:44:15 +0000 (12:44 +1000)
committerMichael Ellerman <mpe@ellerman.id.au>
Tue, 9 Sep 2014 09:02:45 +0000 (19:02 +1000)
commit85101af13bb854a6572fa540df7c7201958624b9
tree9dc8a4dca76dc5e613d5dbcefcbc8e576f8d8bb7
parentc9ac408bc7329911237c25508f578fb2fa1c4235
powerpc/perf: Fix ABIv2 kernel backtraces

ABIv2 kernels are failing to backtrace through the kernel. An example:

39.30%  readseek2_proce  [kernel.kallsyms]    [k] find_get_entry
            |
            --- find_get_entry
               __GI___libc_read

The problem is in valid_next_sp() where we check that the new stack
pointer is at least STACK_FRAME_OVERHEAD below the previous one.

ABIv1 has a minimum stack frame size of 112 bytes consisting of 48 bytes
and 64 bytes of parameter save area. ABIv2 changes that to 32 bytes
with no paramter save area.

STACK_FRAME_OVERHEAD is in theory the minimum stack frame size,
but we over 240 uses of it, some of which assume that it includes
space for the parameter area.

We need to work through all our stack defines and rationalise them
but let's fix perf now by creating STACK_FRAME_MIN_SIZE and using
in valid_next_sp(). This fixes the issue:

30.64%  readseek2_proce  [kernel.kallsyms]    [k] find_get_entry
            |
            --- find_get_entry
               pagecache_get_page
               generic_file_read_iter
               new_sync_read
               vfs_read
               sys_read
               syscall_exit
               __GI___libc_read

Cc: stable@vger.kernel.org # 3.16+
Reported-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: Anton Blanchard <anton@samba.org>
arch/powerpc/include/asm/ptrace.h
arch/powerpc/perf/callchain.c