ipmi: Don't flush messages in sender() in run-to-completion mode
authorHidehiro Kawai <hidehiro.kawai.ez@hitachi.com>
Mon, 27 Jul 2015 05:55:16 +0000 (14:55 +0900)
committerCorey Minyard <cminyard@mvista.com>
Thu, 3 Sep 2015 20:02:28 +0000 (15:02 -0500)
commit82802f968bd3118af04eaeb3814c21d9813be527
treedd26a8d2a0d96b013938814083144654bf30db71
parente45361d733d0a1432b0f6307375045e66ac02489
ipmi: Don't flush messages in sender() in run-to-completion mode

When flushing queued messages in run-to-completion mode,
smi_event_handler() is recursively called.

flush_messages()
 smi_event_handler()
  handle_transaction_done()
   deliver_recv_msg()
    ipmi_smi_msg_received()
     smi_recv_tasklet()
      sender()
       flush_messages()
        smi_event_handler()
         ...

The depth of the recursive call depends on the number of queued
messages, so it can cause a stack overflow if many messages have
been queued.

To solve this problem, this patch removes flush_messages()
from sender()@ipmi_si_intf.c.  Instead, add flush_messages() to
caller side of sender() if needed.  Additionally, to implement this,
add new handler flush_messages to struct ipmi_smi_handlers.

Signed-off-by: Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com>
Fixed up a comment and some spacing issues.

Signed-off-by: Corey Minyard <cminyard@mvista.com>
drivers/char/ipmi/ipmi_msghandler.c
drivers/char/ipmi/ipmi_si_intf.c
include/linux/ipmi_smi.h