drm/i915: Cancel hangcheck before GPU is suspended
authorJoonas Lahtinen <joonas.lahtinen@linux.intel.com>
Wed, 9 Dec 2015 13:56:13 +0000 (15:56 +0200)
committerImre Deak <imre.deak@intel.com>
Thu, 10 Dec 2015 09:28:05 +0000 (11:28 +0200)
commit825f272895b9ec9151399b4102739c899b0b6392
treeb4cff12e4458bd3368361498160dd7af7692ac02
parent3d52ccf52f2c51f613e42e65be0f06e4e6788093
drm/i915: Cancel hangcheck before GPU is suspended

In order to avoid accessing GPU registers while GPU is suspended cancel
the hangcheck work before calling intel_suspend_complete which actually
puts the GPU to suspend. Otherwise hangcheck might do MMIO reads to a
suspended GPU.

Placement before intel_guc_suspend is imitated from i915_drm_suspend
which cancels the work at i915_gem_suspend, to keep the functions
similar.

On VLV systems, namely BYT, this was causing an error during runtime
suspend cycle:

[drm:vlv_check_no_gt_access [i915]] *ERROR* GT register access while GT waking disabled

Testcase: igt/pm_rpm/basic-rte
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93121

Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Imre Deak <imre.deak@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Link: http://patchwork.freedesktop.org/patch/msgid/1449669373-8588-1-git-send-email-joonas.lahtinen@linux.intel.com
Reviewed-by: Imre Deak <imre.deak@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Imre Deak <imre.deak@intel.com>
drivers/gpu/drm/i915/i915_drv.c